Configure dir.yaml for multi-sidebars (r5.8)#3386
Open
Meggielqk wants to merge 38 commits intorelease-5.8from
Open
Configure dir.yaml for multi-sidebars (r5.8)#3386Meggielqk wants to merge 38 commits intorelease-5.8from
Meggielqk wants to merge 38 commits intorelease-5.8from
Conversation
When Japanese translation files don't exist (e.g. versions before v5.9), fall back to English titles instead of crashing with FileNotFoundError. Also skip move_manual when source/target doesn't exist.
When a language's md file doesn't exist, skip the entry entirely rather than falling back to English titles. This avoids generating sidebar/nav entries for unsupported languages (e.g. ja before v5.9).
Detect supported languages by checking if language directories have real doc content (not just auto-generated configuration manual). Versions before v5.9 without ja_JP docs will no longer produce ja entries in directory.json.
shutil.copyfile fails when the target directory doesn't exist (e.g. fresh clone without residual files from other branches).
Configuration manual is no longer generated via move_manual. Remove the function, shutil import, cfg-manual-docgen/ directory, and clean up typos exclude list.
…qx/emqx-docs into 260310-config-horizontal-menu
zmstone
reviewed
Apr 23, 2026
zmstone
reviewed
Apr 23, 2026
zmstone
reviewed
Apr 23, 2026
Member
zmstone
left a comment
There was a problem hiding this comment.
Add a security note: when proxy protocol is enabled for a EMQX listener, make sure this endpoint is not exposed to public, firewall rules should be implemented to only allow the designated proxy/LB to connect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.