Skip to content

Configure dir.yaml for multi-sidebars (r5.8)#3386

Open
Meggielqk wants to merge 38 commits intorelease-5.8from
260310-config-horizontal-menu
Open

Configure dir.yaml for multi-sidebars (r5.8)#3386
Meggielqk wants to merge 38 commits intorelease-5.8from
260310-config-horizontal-menu

Conversation

@Meggielqk
Copy link
Copy Markdown
Collaborator

No description provided.

@Meggielqk Meggielqk added this to the 5.8.9 milestone Mar 10, 2026
Meggielqk and others added 28 commits March 13, 2026 20:16
When Japanese translation files don't exist (e.g. versions before v5.9),
fall back to English titles instead of crashing with FileNotFoundError.
Also skip move_manual when source/target doesn't exist.
When a language's md file doesn't exist, skip the entry entirely
rather than falling back to English titles. This avoids generating
sidebar/nav entries for unsupported languages (e.g. ja before v5.9).
Detect supported languages by checking if language directories have
real doc content (not just auto-generated configuration manual).
Versions before v5.9 without ja_JP docs will no longer produce
ja entries in directory.json.
shutil.copyfile fails when the target directory doesn't exist
(e.g. fresh clone without residual files from other branches).
Configuration manual is no longer generated via move_manual.
Remove the function, shutil import, cfg-manual-docgen/ directory,
and clean up typos exclude list.
@Meggielqk Meggielqk marked this pull request as ready for review April 13, 2026 08:04
Comment thread en_US/operate/cluster/proxy-protocol.md Outdated
Comment thread en_US/operate/cluster/proxy-protocol.md Outdated
Copy link
Copy Markdown
Member

@zmstone zmstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a security note: when proxy protocol is enabled for a EMQX listener, make sure this endpoint is not exposed to public, firewall rules should be implemented to only allow the designated proxy/LB to connect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants